Skip to content

fix(kiloclaw): show setup errors after provision failures#2556

Merged
RSO merged 3 commits into
mainfrom
RSO/meadow-badger
Apr 21, 2026
Merged

fix(kiloclaw): show setup errors after provision failures#2556
RSO merged 3 commits into
mainfrom
RSO/meadow-badger

Conversation

@RSO
Copy link
Copy Markdown
Contributor

@RSO RSO commented Apr 17, 2026 •
edited
Loading

Summary

  • Adds an explicit setup-failure signal so KiloClaw onboarding renders the error step when provisioning fails before a durable instance status exists.
  • Records safe provision-failure analytics for the worker platform route, including Fly operation/status labels without storing upstream HTML bodies.
  • Covers personal and organization onboarding flows plus state-machine and platform route tests.

Reviewer Notes

  • The client-side PostHog event intentionally records only a generic failure reason, not the raw error message.
  • The worker analytics event stores sanitized error and classified label values so Fly HTML error bodies do not enter Analytics Engine.

@RSO RSO marked this pull request as ready for review April 21, 2026 08:47
kilo-code-bot[bot]
kilo-code-bot Bot reviewed Apr 21, 2026
View reviewed changes
Comment thread apps/web/src/app/(app)/organizations/[id]/claw/new/OrgClawNewClient.tsx
<ClawOnboardingWithBoundary
statusQuery={{ ...statusQuery, data: settledStatus }}
statusQuery={{
...statusQuery,
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: setupFailed can still leave the org flow stuck on the loading boundary

This branch clears error, but it still spreads statusQuery.isLoading. If provisioning fails before the first org status poll settles, withStatusQueryBoundary keeps rendering Loading... and the new error step never appears. The personal flow already forces isLoading: false; the org path needs the same override.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 21, 2026 •
edited
Loading

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/app/(app)/organizations/[id]/claw/new/OrgClawNewClient.tsx 108 setupFailed still preserves statusQuery.isLoading, so a failed org provisioning request can stay stuck on the loading boundary instead of showing the new error step.
Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

None.

Files Reviewed (8 files)
  • apps/web/src/app/(app)/claw/components/ClawOnboardingFlow.state.test.ts - 0 issues
  • apps/web/src/app/(app)/claw/components/ClawOnboardingFlow.state.ts - 0 issues
  • apps/web/src/app/(app)/claw/components/ClawOnboardingFlow.tsx - 0 issues
  • apps/web/src/app/(app)/claw/components/CreateInstanceCard.tsx - 0 issues
  • apps/web/src/app/(app)/claw/new/ClawNewClient.tsx - 0 issues
  • apps/web/src/app/(app)/organizations/[id]/claw/new/OrgClawNewClient.tsx - 1 issue
  • services/kiloclaw/src/routes/platform-sanitize-error.test.ts - 0 issues
  • services/kiloclaw/src/routes/platform.ts - 0 issues

Fix these issues in Kilo Cloud

Reviewed by gpt-5.4-20260305 · 542,989 tokens

@RSO RSO merged commit 9aa6afe into main Apr 21, 2026
16 checks passed
@RSO RSO deleted the RSO/meadow-badger branch April 21, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilo-code-bot kilo-code-bot[bot] kilo-code-bot[bot] left review comments

@jeanduplessis jeanduplessis jeanduplessis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RSO @jeanduplessis